Specify NODE_ENV in the production build command #1053
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
Recently webpacker gem has been updated in a way to make
NODE_ENV
not fallback toRAILS_ENV
(rails/webpacker@e616184).By default react_on_rails generates this config:
Before the change in webpacker, this was effectively setting both
RAILS_ENV
andNODE_ENV
to "production", but not anymore. NowNODE_ENV
defaults to "development". So if you don't specify it, your production assets will be compiled using dev settings.This change is