Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version checking mismatch bug #1062

Closed
dzirtusss opened this issue Apr 20, 2018 · 4 comments
Closed

Version checking mismatch bug #1062

dzirtusss opened this issue Apr 20, 2018 · 4 comments
Labels
bug easy low priority

Comments

@dzirtusss
Copy link
Contributor

There is a possibility of versions mismatch when version in package.json is accidentally specified in non-exact style e.g. ^10.1.3. If later version is bumped to say 10.1.4 in node packages this is not noticed by the gem.

I guess this could be fixed easily by forcing only exact version in package.json by version_checker.rb, or at least having a warning that version is not exact.
@justin808
Copy link
Member

Here is the file to change: https://github.com/shakacode/react_on_rails/blob/49401b2b48aaf397de625f988ab0617ed4499fc4/lib/react_on_rails/version_checker.rb

and the test to update: https://github.com/shakacode/react_on_rails/blob/94868d0810a4f0e51b8e8d7ed79d73d7bcaae342/spec/react_on_rails/version_checker_spec.rb

@justin808
Copy link
Member

Good description:
https://stackoverflow.com/a/31733623/1009332

@justin808
Copy link
Member

rubygems/bundler#6500 to see if I can find out if the ruby gem has a semver wildcard.

justin808 added a commit that referenced this issue Apr 21, 2018
@justin808
More exact version checking
8e1ea05 
We keep the react_on_rails gem and the react-on-rails node package at
the same exact versions so that we can be sure that the interaction
between them is precise.

This is so that if a bug is detected after some update, it's critical that
both the gem and the node package get the updates.

This change ensures that the package.json specification does not use a
~ or ^ as reported in #1062
@justin808 justin808 mentioned this issue Apr 21, 2018
Merged
@justin808
Copy link
Member

Fixed in #1063.

justin808 added a commit that referenced this issue Apr 21, 2018
@justin808
More exact version checking
ea76d76 
We keep the react_on_rails gem and the react-on-rails node package at
the same exact versions so that we can be sure that the interaction
between them is precise.

This is so that if a bug is detected after some update, it's critical that
both the gem and the node package get the updates.

This change ensures that the package.json specification does not use a
~ or ^ as reported in #1062
justin808 added a commit that referenced this issue Apr 21, 2018
@justin808
More exact version checking
c8d77eb 
We keep the react_on_rails gem and the react-on-rails node package at
the same exact versions so that we can be sure that the interaction
between them is precise.

This is so that if a bug is detected after some update, it's critical that
both the gem and the node package get the updates.

This change ensures that the package.json specification does not use a
~ or ^ as reported in #1062
justin808 added a commit that referenced this issue Apr 21, 2018
@justin808
More exact version checking (#1063)
0cb3768 
We keep the react_on_rails gem and the react-on-rails node package at
the same exact versions so that we can be sure that the interaction
between them is precise.

This is so that if a bug is detected after some update, it's critical that
both the gem and the node package get the updates.

This change ensures that the package.json specification does not use a
~ or ^ as reported in #1062
superdev9082 added a commit to superdev9082/react_on_rails that referenced this issue Feb 16, 2023
@superdev9082
More exact version checking (#1063)
b343863 
We keep the react_on_rails gem and the react-on-rails node package at
the same exact versions so that we can be sure that the interaction
between them is precise.

This is so that if a bug is detected after some update, it's critical that
both the gem and the node package get the updates.

This change ensures that the package.json specification does not use a
~ or ^ as reported in shakacode/react_on_rails#1062
Web-Go-To added a commit to Web-Go-To/react-with-rails that referenced this issue Mar 19, 2023
@Web-Go-To
More exact version checking (#1063)
45b1e00 
We keep the react_on_rails gem and the react-on-rails node package at
the same exact versions so that we can be sure that the interaction
between them is precise.

This is so that if a bug is detected after some update, it's critical that
both the gem and the node package get the updates.

This change ensures that the package.json specification does not use a
~ or ^ as reported in shakacode/react_on_rails#1062
@coderabbitai coderabbitai bot mentioned this issue Jun 27, 2024
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug easy low priority
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@justin808 @dzirtusss