Skip to content

Commit

Permalink
Mention that 'react-dom' also needs to be in webpack.conf; fix typo
Browse files Browse the repository at this point in the history
  • Loading branch information
squadette committed Jan 7, 2017
1 parent 4a41f8e commit 317dc5d
Showing 1 changed file with 2 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -86,7 +86,7 @@ npm install --save "react-on-rails@../../react_on_rails"

When you use a relative path, be sure to run the above `npm install` command whenever you change the node package for react-on-rails.

Wihle we'd prefer to us `npm link`, we get errors. If you can figure out how to get `npm link react-on-rails` to work with this project, please file an issue or PR! This used to work with babel 5.
While we'd prefer to use `npm link`, we get errors. If you can figure out how to get `npm link react-on-rails` to work with this project, please file an issue or PR! This used to work with babel 5.

This is the error:

Expand Down Expand Up @@ -141,6 +141,7 @@ From now on, the example and dummy apps will use your local node_package folder
resolve: {
alias: {
react: path.resolve('./node_modules/react'),
'react-dom': path.resolve('./node_modules/react-dom'),
},
},
```
Expand Down

0 comments on commit 317dc5d

Please sign in to comment.