Upgrade to Rails 5.0.0.beta3 #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- ran `rails rails:update` - also updated rspec-rails to 3.5.0.beta3 for rails 5 compatibility - modified puma config
|
If this update looks good, deploys to Heroku cleanly, etc, a next step would be updating the README to reflect the change to Rails 5. |
Fixes ActiveRecord::StatementInvalid: SQLite3::SQLException: near ",": syntax error: INSERT INTO "schema_migrations" see: rails/rails#24288
|
@audionerd We need to fix CI. Let me know if you need my help with that. |
|
Reviewed 16 of 23 files at r1, 1 of 1 files at r2, 5 of 8 files at r3. Comments from Reviewable |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rails rails:updatechanges to puma.rb (following the Rails 5 recommendation):
RAILS_MAX_THREADSinstead ofMAX_THREADSrackup DefaultRackupFixes #220
This change is