Minify js in production. #234
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
2.3 MB ==> 600K 👏 👏 👏 |
| sh "cd client && npm run build:client" | ||
| sh "cd client && npm run build:server" | ||
| sh "cd client && npm run build:production:client" | ||
| sh "cd client && npm run build:production:server" |
9c0cb5c to
cc9fafc
Compare
|
I removed the extraneous webpack uglify plugin code, so we're just relying on the rails asset pipeline for now. It sounds like further optimization may be possible, but I think that can be accomplished in other PRs. EDIT somehow messed up that commit, and only changed the message. The uglify plugin should actually be gone now. |
The rake asset compilation task will now run the production-specific npm build scripts.
cc9fafc to
7f62253
Compare
This was referenced Feb 24, 2016
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The rake asset compilation task will now run the production-specific npm build scripts, which employ the
UglifyJsPluginplugin.There may be reasons I'm not aware of to not do this, but this is what I would assume would happen for a production build, which is generally what you're targeting when running asset precompilation.
The numbers below just approximately sum vendor and app bundles.
current
bin/rake assets:precompile(total approx 6.1 MB)explicitly running npm prod builds in
bin/rake assets:precompile(total approx 2.3 MB)explicitly running npm prod builds in
bin/rake assets:precompileAND adding minification plugin (total approx 600 KB)