Skip to content

Commit

Permalink
Ignore warning for react-dom/client not found (#519)
Browse files Browse the repository at this point in the history
* Ignore warning for react-dom/client not found
* Revert "Ignore warning for react-dom/client not found"
This reverts commit a5f38b6.
* Ignore warning for react-dom/client not found
  • Loading branch information
ahangarha authored Mar 15, 2023
1 parent e457dd7 commit a7a0aa1
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion config/webpack/commonWebpackConfig.js
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,17 @@ const sassLoaderConfig = {
},
};

const ignoreWarningsConfig = {
ignoreWarnings: [/Module not found: Error: Can't resolve 'react-dom\/client'/],
};

const scssConfigIndex = baseClientWebpackConfig.module.rules.findIndex((config) =>
'.scss'.match(config.test),
);

baseClientWebpackConfig.module.rules[scssConfigIndex].use.push(sassLoaderConfig);

// Copy the object using merge b/c the baseClientWebpackConfig and commonOptions are mutable globals
const commonWebpackConfig = () => merge({}, baseClientWebpackConfig, commonOptions);
const commonWebpackConfig = () => merge({}, baseClientWebpackConfig, commonOptions, ignoreWarningsConfig);

module.exports = commonWebpackConfig;

0 comments on commit a7a0aa1

Please sign in to comment.