fix: Evict the buffer against seekRangeStart #8026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This avoid keep in the buffer content that is not necessary.
avelad
commented
Feb 6, 2025
| @@ -1424,7 +1424,7 @@ shaka.media.MediaSourceEngine = class { | |||
| const ContentType = shaka.util.ManifestParserUtils.ContentType; | |||
| if (contentType == ContentType.TEXT) { | |||
| await this.textEngine_.remove(startTime, endTime); | |||
| } else { | |||
| } else if (endTime > startTime) { | |||
There was a problem hiding this comment.
This is an optimization to avoid adding an operation that would do nothing.
avelad
commented
Feb 6, 2025
lib/media/streaming_engine.js
Outdated
| this.manifest_.presentationTimeline.getSeekRangeEnd(); | ||
|
|
||
| let overflow = bufferedBehind - bufferBehind; | ||
| if (seekRangeEnd - seekRangeStart > 1) { |
There was a problem hiding this comment.
Some platforms require more than 1 second of buffer, otherwise errors occur.
tykus160
approved these changes
Feb 6, 2025
|
Incremental code coverage: 100.00% |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This avoid keep in the buffer content that is not necessary.