Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Use audio label on ExampleBasedCriteria #7971

Merged
merged 2 commits into from
Jan 29, 2025

Conversation

avelad
Copy link
Member

@avelad avelad commented Jan 28, 2025

Fixes #7968

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Jan 28, 2025
@avelad avelad added this to the v4.14 milestone Jan 28, 2025
@avelad avelad removed the component: UI The issue involves the Shaka Player UI label Jan 28, 2025
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

lib/media/example_based_criteria.js Outdated Show resolved Hide resolved
Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
@avelad avelad requested a review from tykus160 January 29, 2025 09:11
@avelad avelad merged commit b491e4a into shaka-project:main Jan 29, 2025
16 of 18 checks passed
@avelad avelad deleted the example-criteria-label branch January 29, 2025 09:39
avelad added a commit that referenced this pull request Jan 29, 2025
Fixes #7968

---------

Co-authored-by: Wojciech Tyczyński <tykus160@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

UI Language track reverting after some seconds
3 participants