Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(UI): Don't try to add MediaSessionHandler for PiP when it's not available #7376

Merged
merged 1 commit into from
Sep 25, 2024
Merged

fix(UI): Don't try to add MediaSessionHandler for PiP when it's not available #7376

merged 1 commit into from
Sep 25, 2024

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 25, 2024

No description provided.

@avelad avelad added type: bug Something isn't working correctly component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround labels Sep 25, 2024
@avelad avelad added this to the v4.12 milestone Sep 25, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 100.00%

@avelad avelad merged commit e71dca2 into shaka-project:main Sep 25, 2024
21 of 23 checks passed
@shaka-bot shaka-bot mentioned this pull request Sep 25, 2024
Merged
avelad added a commit that referenced this pull request Sep 25, 2024
@avelad
fix(UI): Don't try to add MediaSessionHandler for PiP when it's not a…
25eb8c0 
…vailable (#7376)
@shaka-bot shaka-bot mentioned this pull request Sep 25, 2024
Merged
@avelad avelad deleted the pip-media-session branch October 18, 2024 06:41
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Nov 24, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Nov 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tykus160 tykus160 tykus160 approved these changes

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

@theodab theodab Awaiting requested review from theodab

Assignees
No one assigned
Labels
component: UI The issue involves the Shaka Player UI priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.12
Development

Successfully merging this pull request may close these issues.
3 participants
@avelad @shaka-bot @tykus160