-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(DASH): Parse and use target latency #6683
Conversation
Incremental code coverage: 64.44% |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Is there a reason for not adding the target latency as on option as well? Or just want that to be as part of the updated #6193?
By rereading again, then min and max stop making sense, because we would always use target if we use liveSync = true. So there are two options:
Since in both options you have to do this PR, I have gone for the simple thing. But I would like to hear your opinion. |
It's a bit tricky. From the DASH spec, the only property that's required is target latency. From my understanding, the DASH spec is also a bit stricter in terms of what max and min latency mean, where playback should happen in those areas (potentially, triggering a seek to the target latency?). |
After this PR I will work on making the configuration simpler, so I will add |
Related to #6193
Thanks to @gkatsev