Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Issue with compiler minifying webOS device properties #6554

Conversation

stuartflanagan
Copy link

@stuartflanagan stuartflanagan commented May 8, 2024

Fixes #6533

- Use Array access notation instead of dot notation
Copy link

google-cla bot commented May 8, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@stuartflanagan
Copy link
Author

Fixes: #6533

@avelad
Copy link
Member

avelad commented May 8, 2024

@stuartflanagan please sign the CLA!

@avelad avelad added type: bug Something isn't working correctly priority: P1 Big impact or workaround impractical; resolve before feature release platform: WebOS Issues affecting WebOS labels May 8, 2024
@avelad avelad added this to the v4.9 milestone May 8, 2024
@avelad avelad changed the title fix: Issue with compiler minifying webOS device properties #6533 fix: Issue with compiler minifying webOS device properties May 8, 2024
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 33.33%

@avelad
Copy link
Member

avelad commented May 8, 2024

@stuartflanagan Once the CLA is signed I will merge the PR.

@stuartflanagan
Copy link
Author

@avelad if there is a reason I cannot sign the CLA can I pass the code onto you or another developer?

@avelad
Copy link
Member

avelad commented May 8, 2024

@stuartflanagan If you give me permission, I can do it, but if you can sign the CLA I prefer that you do it and take the authorship of this fix.

@stuartflanagan
Copy link
Author

Will get back to you tomorrow. Thank you for your help @avelad

@avelad
Copy link
Member

avelad commented May 8, 2024

Will get back to you tomorrow. Thank you for your help @avelad

I created #6558, but I'll wait until you can say your final answer before doing anything. Thanks!

@stuartflanagan
Copy link
Author

Please go ahead and merge yours when ready. I will close mine now.

@stuartflanagan stuartflanagan deleted the fix-lg-support-regression branch May 8, 2024 11:09
avelad added a commit that referenced this pull request May 8, 2024
avelad added a commit that referenced this pull request May 8, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jul 7, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jul 7, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
platform: WebOS Issues affecting WebOS priority: P1 Big impact or workaround impractical; resolve before feature release status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

webOS 4032 error in compiled version but not debug version
5 participants