Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Handle non existing navigator.platform string (#6517) #6518

Merged
merged 3 commits into from
Apr 30, 2024
Merged

fix: Handle non existing navigator.platform string (#6517) #6518

merged 3 commits into from
Apr 30, 2024

Conversation

MichaelSweden
Copy link
Contributor

@MichaelSweden MichaelSweden commented Apr 30, 2024 •
edited by avelad
Loading

This fix will make it possible to use v4.8 in Cobalt browser. The problem is that navigator.platform doesn't exist in Cobalt browser.

Fixes #6517

avelad
avelad reviewed Apr 30, 2024
View reviewed changes
@avelad avelad added type: bug Something isn't working correctly priority: P2 Smaller impact or easy workaround labels Apr 30, 2024
@avelad avelad added this to the v4.9 milestone Apr 30, 2024
@avelad avelad merged commit f337e06 into shaka-project:main Apr 30, 2024
12 of 15 checks passed
@shaka-bot shaka-bot mentioned this pull request Apr 30, 2024
Merged
@MichaelSweden
Copy link
Contributor Author

Thanks
Tested OK on two different Cobalt platform/versions.

@MichaelSweden MichaelSweden deleted the issue6517 branch April 30, 2024 14:54
@shaka-bot
Copy link
Collaborator

Incremental code coverage: 0.00%

avelad added a commit that referenced this pull request May 6, 2024
@MichaelSweden @avelad
fix: Handle non existing navigator.platform string (#6517) (#6518)
feb176c 
This fix will make it possible to use v4.8 in Cobalt browser. The
problem is that navigator.platform doesn't exist in Cobalt browser.

Fixes #6517

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@shaka-bot shaka-bot mentioned this pull request May 6, 2024
Merged
joeyparrish pushed a commit that referenced this pull request May 7, 2024
@MichaelSweden @avelad @joeyparrish
fix: Handle non existing navigator.platform string (#6517) (#6518)
9a3b047 
This fix will make it possible to use v4.8 in Cobalt browser. The
problem is that navigator.platform doesn't exist in Cobalt browser.

Fixes #6517

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@shaka-bot shaka-bot mentioned this pull request May 7, 2024
Merged
joeyparrish pushed a commit that referenced this pull request May 7, 2024
@MichaelSweden @avelad @joeyparrish
fix: Handle non existing navigator.platform string (#6517) (#6518)
3747b8e 
This fix will make it possible to use v4.8 in Cobalt browser. The
problem is that navigator.platform doesn't exist in Cobalt browser.

Fixes #6517

---------

Co-authored-by: Álvaro Velad Galván <ladvan91@hotmail.com>
@shaka-bot shaka-bot mentioned this pull request May 7, 2024
Merged
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Jun 29, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Jun 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@avelad avelad avelad approved these changes

Assignees
No one assigned
Labels
priority: P2 Smaller impact or easy workaround status: archived Archived and locked; will not be updated type: bug Something isn't working correctly
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

Cannot create a Shaka Player in Cobalt
3 participants
@MichaelSweden @shaka-bot @avelad