Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Use ManagedMediaSource when available #5683

Merged
merged 7 commits into from
Oct 11, 2023
Merged

feat: Use ManagedMediaSource when available #5683

merged 7 commits into from
Oct 11, 2023

Conversation

avelad
Copy link
Member

@avelad avelad commented Sep 26, 2023 •
edited
Loading

The spec can be seen at w3c/media-source#320

Closes #5271

@avelad avelad marked this pull request as draft September 26, 2023 13:13
@avelad avelad added type: enhancement New feature or request priority: P3 Useful but not urgent labels Sep 26, 2023
@avelad
Copy link
Member Author

avelad commented Sep 26, 2023

@joeyparrish , should we polyfill ManagedMediaSource at https://github.com/shaka-project/shaka-player/blob/main/lib/polyfill/mediasource.js?

@shaka-bot
Copy link
Collaborator

shaka-bot commented Sep 26, 2023 •
edited
Loading

Incremental code coverage: 72.46%

@avelad avelad closed this Sep 28, 2023
@avelad avelad deleted the managed-media-source branch September 28, 2023 07:58
@avelad avelad restored the managed-media-source branch September 28, 2023 07:58
@avelad avelad reopened this Sep 28, 2023
@joeyparrish
Copy link
Member

@joeyparrish , should we polyfill ManagedMediaSource at https://github.com/shaka-project/shaka-player/blob/main/lib/polyfill/mediasource.js?

I don't believe so. It should be a fallback. If ManagedMediaSource exists, use that, otherwise, use MediaSource. The polyfill is only needed at that lowest level IMO.

@avelad
Merge branch 'main' into managed-media-source
9ac7040 
# Conflicts:
#	lib/media/media_source_engine.js
@avelad avelad marked this pull request as ready for review October 5, 2023 06:42
@avelad avelad added this to the v4.6 milestone Oct 5, 2023
@avelad
Copy link
Member Author

avelad commented Oct 9, 2023 •
edited
Loading

@theodab @joeyparrish I have implemented all the specification, so it is ready to be reviewed. You can test it now with Safari 17 on macOS Sonoma or iPadOS.

@avelad
Copy link
Member Author

avelad commented Oct 10, 2023

@joeyparrish friendly ping!

@avelad avelad merged commit 01da5fa into shaka-project:main Oct 11, 2023
15 checks passed
@avelad avelad mentioned this pull request Oct 11, 2023
Closed
@shaka-bot shaka-bot mentioned this pull request Oct 11, 2023
Merged
@avelad avelad deleted the managed-media-source branch October 11, 2023 09:29
Robloche pushed a commit to Robloche/shaka-player that referenced this pull request Nov 30, 2023
@avelad
feat: Use ManagedMediaSource when available (shaka-project#5683)
daa37cb 
The spec can be seen at w3c/media-source#320

Closes shaka-project#5271
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 10, 2023
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tykus160 tykus160 tykus160 left review comments

@theodab theodab theodab approved these changes

@littlespex littlespex Awaiting requested review from littlespex

@joeyparrish joeyparrish Awaiting requested review from joeyparrish

Assignees
No one assigned
Labels
priority: P3 Useful but not urgent status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v4.6
Development

Successfully merging this pull request may close these issues.

Support through Managed MSE
5 participants
@avelad @shaka-bot @joeyparrish @theodab @tykus160