-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add serverCertificateUri in DRM advanced config #3358
feat: add serverCertificateUri in DRM advanced config #3358
Conversation
.addLicenseServer('com.widevine.alpha', 'https://cwip-shaka-proxy.appspot.com/no_auth'), | ||
.addLicenseServer('com.widevine.alpha', 'https://cwip-shaka-proxy.appspot.com/no_auth') | ||
.setExtraConfig({drm: {advanced: {'com.widevine.alpha': {serverCertificateUri: | ||
'https://storage.googleapis.com/wvmedia/cert/cert_license_widevine_com_uat.bin'}}}}), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This isn't really needed as the CDM will request it for us anyway. I'd suggest dropping the demo changes to make things simpler.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep, it was just to have a working example with the serverCertificateUri. I could drop it or comment to explain this shouldn't be needed, but it is here to demonstrate the feature, WYT ?
7360ea4
to
74c86a9
Compare
@TheModMaker 👋 I've pushed some edits base on your review, thanks ! |
Test Failure:
|
All tests passed! |
Description
Fixes #1906
Type of change
not work as expected)
Checklist:
./build/all.py
and the build passes./build/test.py
and all tests passWorks when running alone but doesn't when running with all the other tests (same thing on master)