Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default timeout network requests #3024

Merged
merged 2 commits into from
Dec 17, 2020

Conversation

avelad
Copy link
Member

@avelad avelad commented Dec 3, 2020

Closes: #1578

We are having problems with Chromecast-CAF and since it uses ShakaPlayer it is necessary to change this here by default.

@joeyparrish
Copy link
Member

Changing a default would potentially impact many different apps. I'm not worried about this particular change too much, but have you tried reconfiguring CAF instead?

@avelad
Copy link
Member Author

avelad commented Dec 3, 2020

The problem is that in CAF there is no way to configure this, so I would like to change it here.

Copy link
Contributor

@valotvince valotvince left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 We experience the same issues in CAF, 30s seems to be a nice limit (on our side we put 15s to allow ABR to quickly switch of representation and prevent a stream interruption)

@avelad
Copy link
Member Author

avelad commented Dec 9, 2020

@joeyparrish can you review it?

@avelad
Copy link
Member Author

avelad commented Dec 16, 2020

It's a simple change, I hope it can be revised soon... :(

@joeyparrish
Copy link
Member

I'm sorry for the delays. We are understaffed at the moment and badly behind on many things. The reminders are appreciated and they do help.

This change should be fairly benign, but will first appear in v3.1, to try to avoid any surprise changes in behavior in the release branches.

However, I will discuss this with the CAF team internally and see if there's a better way to get you what you need before v3.1. Changing Shaka is not an ideal way to address a shortcoming of the CAF API.

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 40a0b36 into shaka-project:master Dec 17, 2020
@avelad avelad deleted the timeout-network-requests branch December 18, 2020 07:39
@avelad
Copy link
Member Author

avelad commented Dec 18, 2020

@joeyparrish Do you have any news from the CAF team?

@joeyparrish
Copy link
Member

They have agreed to adopt this new default in their next release, whether or not they are shipping with Shaka v3.1. There is an ongoing conversation about some way to offer configuration in CAF to allow apps to choose their own timeouts.

I don't know when the next CAF release will come out, but it won't be in 2020. They are on a production freeze right now, and many on the team are on vacation for the rest of the year.

@avelad
Copy link
Member Author

avelad commented Dec 21, 2020

Thanks @joeyparrish !

@avelad
Copy link
Member Author

avelad commented Jan 13, 2021

@joeyparrish , do you have a date when the CAF team is going to include this change in timeouts?

We have some problems in production with this, and the customer is asking me to know when the change will be available.

@joeyparrish
Copy link
Member

It appears that their next release will be in February, but I don't have a more specific date from them. They told me there will be some multi-week preview/beta period in which partners can opt-in before the next release is pushed to everyone. I don't know what the process for that will be.

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Change default timeout network requests
4 participants