Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for EXT-X-SESSION-DATA #2642

Merged
merged 8 commits into from
Jun 17, 2020
Merged

Add support for EXT-X-SESSION-DATA #2642

merged 8 commits into from
Jun 17, 2020

Conversation

avelad
Copy link
Member

@avelad avelad commented Jun 10, 2020

Resolves: #1460

joeyparrish
joeyparrish requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good otherwise. Thanks!

@avelad avelad requested a review from joeyparrish June 16, 2020 07:33
@michellezhuogg
Copy link
Contributor

Could you please rebase and squash your commits into one commit?

@avelad
Copy link
Member Author

avelad commented Jun 16, 2020

@michellezhuogg This morning I did the merge of the master branch. Why do you need to squash my commits into one? Is it a new policy for making contributions?

@michellezhuogg
Copy link
Contributor

@avelad Oh no worries. Sorry that I forgot Github can squash and merge the commit automatically.

joeyparrish
joeyparrish requested changes Jun 16, 2020
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks! Can you add a test of some kind for the HLS parser?

@joeyparrish joeyparrish added the type: enhancement New feature or request label Jun 16, 2020
@avelad
Copy link
Member Author

avelad commented Jun 17, 2020

I added some tests

@avelad avelad requested a review from joeyparrish June 17, 2020 11:08
@avelad avelad requested a review from joeyparrish June 17, 2020 18:01
joeyparrish
joeyparrish approved these changes Jun 17, 2020
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 8f36ae5 into shaka-project:master Jun 17, 2020
@avelad avelad deleted the session-data branch June 18, 2020 05:38
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for EXT-X-SESSION-DATA
4 participants
@avelad @michellezhuogg @shaka-bot @joeyparrish