Add option to customize the polling of expiration time #2579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joeyparrish
requested changes
May 20, 2020
demo/config.js
Outdated
| 'drm.logLicenseExchange') | ||
| .addNumberInput_(MessageIds.UPDATE_EXPIRATION_TIME, | ||
| 'drm.updateExpirationTime', | ||
| /* canBeDecimal= */ false, |
There was a problem hiding this comment.
I think this could reasonably be a non-integer number.
joeyparrish
approved these changes
May 20, 2020
|
All tests passed! |
joeyparrish
pushed a commit
that referenced
this pull request
May 21, 2020
A large value effectively disables use of the expiration time Backported to v2.5.x Closes #2252 Change-Id: I86d019d5031abf435bbd126269df54fa24a583d6
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using higher values in the configuration resolves #2252