Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use label from DASH manifest AdaptationSet #2197

Merged
merged 1 commit into from
Oct 18, 2019
Merged

Use label from DASH manifest AdaptationSet #2197

merged 1 commit into from
Oct 18, 2019

Conversation

avelad
Copy link
Member

@avelad avelad commented Oct 18, 2019

Resolves #2178

joeyparrish
joeyparrish approved these changes Oct 18, 2019
View reviewed changes
Copy link
Member

@joeyparrish joeyparrish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit a1ce0fe into shaka-project:master Oct 18, 2019
TheModMaker pushed a commit that referenced this pull request Nov 6, 2019
@TheModMaker
Use label from DASH manifest AdaptationSet (#2197)
0acbfb9 
Fixes #2178

Change-Id: I6da86cce280d01d183fe110e8986f78784eeaa57
@avelad avelad deleted the dash-label branch March 16, 2022 16:00
@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@joeyparrish joeyparrish joeyparrish approved these changes

Assignees
No one assigned
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Dash audio track name support
3 participants
@avelad @shaka-bot @joeyparrish