-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dolby Vision fixes for Chromecast #1844
Conversation
The Bitly link to Dolby's Dolby Vision Profiles and levels PDF points to a document version that no longer exists. Replace it with a Bitly link to https://www.dolby.com/us/en/technologies/dolby-vision/dolby-vision-profiles-levels.pdf
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
ℹ️ Googlers: Go here for more info. |
I signed the CLA. |
CLAs look good, thanks! ℹ️ Googlers: Go here for more info. |
Dolby Vision is available in 4 different (base) codecs: * dvhe * dvh1 * dvav *dva1 dvh* represents HEVC-based Dolby Vision dva* represents AVC-based Dolby Vision. The dvh1 and dva1 codecs are video formats that store parameter sets in the sample descriptions, rather than the samples. The dvhe and dvav codecs are video formats that store parameter sets in the samples, instead of the sample descriptions. Update the Dolby Vision regular expression to match all four.
No need to remove Dolby Vision codecs on Chromecast. Chromecast's canDisplayType will reject them when the cast receiver or the attached display can't play Dolby Vision. On Dolby Vision capable cast receivers attached to a TV in Dolby Vision mode, canDisplayType does not reject Dolby Vision streams. One such device is the Chromecast Ultra. With this change, Shaka Player plays Dolby Vision on qualifying setups.
I believe I can merge these three Dolby commits in one PR. I'm going to update the PR subject line, though, since this goes beyond fixing the link. |
Test Failure:
|
@bartt, could you fix the linter errors turned up by the build bot? You can also run the linter, compiler, and tests yourself with |
Yeah, I don't do Github pull requests often and didn't realize that all
commits would end up in the same PR.
…On Fri, Mar 15, 2019 at 8:36 AM Joey Parrish ***@***.***> wrote:
I believe I can merge these three Dolby commits in one PR. I'm going to
update the PR subject line, though, since this goes beyond fixing the link.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#1844 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AABscZaji7mIVURommNGvZIYcqw4kg5uks5vW74TgaJpZM4b1CfK>
.
--
*Bart Teeuwisse*
Early riser to hack, build, run, bike, climb & ski. @google engineer.
Formerly @twitter, @yahoo & various startups.
@bartt <https://twitter.com/bartt> • thecodemill.biz
<https://thecodemill.biz/?sig> • Santa Cruz, CA • +1 (831) 480-5106
|
All tests passed! |
Thank you for your contribution! |
The Bitly link to Dolby's Dolby Vision Profiles and levels PDF points to a document version that no longer exists.
Replace it with a Bitly link to https://www.dolby.com/us/en/technologies/dolby-vision/dolby-vision-profiles-levels.pdf