Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dolby Vision fixes for Chromecast #1844

Merged
merged 4 commits into from
Mar 18, 2019
Merged

Conversation

bartt
Copy link
Contributor

@bartt bartt commented Mar 14, 2019

The Bitly link to Dolby's Dolby Vision Profiles and levels PDF points to a document version that no longer exists.

Replace it with a Bitly link to https://www.dolby.com/us/en/technologies/dolby-vision/dolby-vision-profiles-levels.pdf

The Bitly link to Dolby's Dolby Vision Profiles and levels PDF points to a document version that no longer exists. 

Replace it with a Bitly link to https://www.dolby.com/us/en/technologies/dolby-vision/dolby-vision-profiles-levels.pdf
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@bartt
Copy link
Contributor Author

bartt commented Mar 14, 2019

I signed the CLA.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

bartt added 2 commits March 14, 2019 12:43
Dolby Vision is available in 4 different (base) codecs:
* dvhe 
* dvh1
* dvav
*dva1

dvh* represents HEVC-based Dolby Vision
dva* represents AVC-based Dolby Vision.

The dvh1 and dva1 codecs are video formats that store parameter sets in the sample descriptions, rather than the samples.
The dvhe and dvav codecs are video formats that store parameter sets in the samples, instead of the sample descriptions.

Update the Dolby Vision regular expression to match all four.
No need to remove Dolby Vision codecs on Chromecast. Chromecast's canDisplayType will reject them when the cast receiver or the attached display can't play Dolby Vision. 

On Dolby Vision capable cast receivers attached to a TV in Dolby Vision mode, canDisplayType does not reject Dolby Vision streams. One such device is the Chromecast Ultra. With this change, Shaka Player plays Dolby Vision on qualifying setups.
@joeyparrish
Copy link
Member

I believe I can merge these three Dolby commits in one PR. I'm going to update the PR subject line, though, since this goes beyond fixing the link.

@joeyparrish joeyparrish changed the title Fix the link to Dolby's Dolby Vision Profiles and levels PDF Dolby Vision fixes for Chromecast Mar 15, 2019
@shaka-bot
Copy link
Collaborator

Test Failure:

Generating Closure dependencies...
Linting JavaScript...

/var/lib/jenkins/workspace/Manual PR Test (local-tests)/lib/polyfill/mediasource.js
318:1  error  Trailing spaces not allowed  no-trailing-spaces

✖ 1 problem (1 error, 0 warnings)
1 error, 0 warnings potentially fixable with the `--fix` option.

END-BUILD: FAILURE
Build step 'Execute shell' marked build as failure

@joeyparrish
Copy link
Member

@bartt, could you fix the linter errors turned up by the build bot? You can also run the linter, compiler, and tests yourself with python2 build/all.py and python2 build/test.py. Thanks!

@bartt
Copy link
Contributor Author

bartt commented Mar 16, 2019 via email

@shaka-bot
Copy link
Collaborator

All tests passed!

@joeyparrish joeyparrish merged commit 7660edc into shaka-project:master Mar 18, 2019
@joeyparrish joeyparrish added this to the v2.5 milestone Mar 18, 2019
@joeyparrish
Copy link
Member

Thank you for your contribution!

@github-actions github-actions bot added the status: archived Archived and locked; will not be updated label Jul 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants