-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add new request type TIMING for clock sync requests #1489
Add new request type TIMING for clock sync requests #1489
Conversation
We found a Contributor License Agreement for you (the sender of this pull request), but were unable to find agreements for all the commit author(s) or Co-authors. If you authored these, maybe you used a different email address in the git commits than was used to sign the CLA (login here to double check)? If these were authored by someone else, then they will need to sign a CLA as well, and confirm that they're okay with these being contributed to Google. |
2170459
to
671d307
Compare
CLAs look good, thanks! |
Looks good, but can you please update CONTRIBUTORS and AUTHORS as well? There are notes at the top about how to do that, but please make sure to keep them alphabetized. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me. Thanks!
I'm just going to have the build bot check it out. It's not doing anything magical, so it if it reports any failures, just run build/all.py and build/test.py locally to reproduce. If all the tests pass, I'll merge it. |
Test Failure:
|
Looks like one test needs updating. You can check results locally with build/all.py (to lint and compile everything) and build/test.py (to run the tests). Thanks! |
All tests passed! |
Thanks for your contribution! |
Adds shaka.net.NetworkingEngine.RequestType.TIMING for identification of clock sync requests in networking filters. Fixes #1488.