Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HLS NAME attribute not supported #825

Closed
joeyparrish opened this issue May 19, 2017 · 3 comments
Closed

HLS NAME attribute not supported #825

joeyparrish opened this issue May 19, 2017 · 3 comments
Assignees
@joeyparrish
Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: enhancement New feature or request
Milestone
v2.2.0

Comments

@joeyparrish
Copy link
Member

When #811 lands, we should add support for the HLS NAME attribute, which would map to the track label.
@joeyparrish joeyparrish added type: enhancement New feature or request component: HLS The issue involves Apple's HLS manifest format labels May 19, 2017
@joeyparrish joeyparrish added this to the v2.2.0 milestone May 19, 2017
@joeyparrish joeyparrish self-assigned this May 19, 2017
@joeyparrish joeyparrish mentioned this issue May 19, 2017
Merged
@yuenghole
Copy link

Thanks a lot, Joey.

Your Shaka Player is fantastic!!!

Besides, may I know when this enhancement will be released?

Thank you very much.

@joeyparrish
Copy link
Member Author

After we land PR #811, we will have all the necessary framework to expose labels. After that, adding support for HLS's NAME attribute will be quick and simple.

As for when it will be released, if you want to work with what's in the master branch, you'll have it much sooner. We will have to review the feature to decide if it makes the cut for v2.1.x or if it waits until v2.2.0. We try not to cherry-pick anything to a release branch that may introduce undue risk.

I'll update this issue when the decision is made.

joeyparrish pushed a commit that referenced this issue Jun 5, 2017
@joeyparrish
Add support for DASH label and HLS NAME attributes (#811)
2841de2 
* add support for non-standard DASH label attribute
* add support for HLS NAME attribute

Closes #825
@joeyparrish
Copy link
Member Author

Cherry-picked to v2.1.3.

@shaka-project shaka-project locked and limited conversation to collaborators Mar 22, 2018
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Apr 15, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@joeyparrish joeyparrish

Labels
component: HLS The issue involves Apple's HLS manifest format status: archived Archived and locked; will not be updated type: enhancement New feature or request
Projects
None yet
Milestone
v2.2.0
Development

No branches or pull requests
3 participants
@joeyparrish @shaka-bot @yuenghole