Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMCDv2: ltc is reported in the wrong format #8010

Closed
costela opened this issue Feb 4, 2025 · 0 comments · Fixed by #8011 · May be fixed by #7962
Closed

CMCDv2: ltc is reported in the wrong format #8010

costela opened this issue Feb 4, 2025 · 0 comments · Fixed by #8011 · May be fixed by #7962
Assignees
Labels
component: CMCD The issue involves CMCD specifically priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Milestone

Comments

@costela
Copy link
Contributor

costela commented Feb 4, 2025

Have you read the FAQ and checked for duplicate open issues?

If the problem is related to FairPlay, have you read the tutorial?

What version of Shaka Player are you using?

Can you reproduce the issue with our latest release version?
Yes

Can you reproduce the issue with the latest code from main?
Yes

Are you using the demo app or your own custom app?
Reproducible both on demo and custom app.

If custom app, can you reproduce the issue using our demo app?
Yes

What browser and OS are you using?
Firefox and Chrome

For embedded devices (smart TVs, etc.), what model and firmware version are you using?
Tizen, Web0S

What are the manifest and license server URIs?

What configuration are you using? What is the output of player.getNonDefaultConfiguration()?

What did you do?

Start any stream with CMCDv2 enabled:

{
  "cmcd": {
    "enabled": true,
    "version": 2
  }
}

What did you expect to happen?
ltc should be an integer millisecond value of the playhead distance to the current time, as specified in the current WIP CMCDv2 spec.

Image

What actually happened?

ltc is a full millisecond timestamp for the first few requests (e.g. 1738664450585) and then becomes a non-rounded number, potentially non-integer (e.g.: 12272.13541), both non-conformant with the spec.

Are you planning to send a PR to fix it?
Yes 🔧

@costela costela added the type: bug Something isn't working correctly label Feb 4, 2025
@shaka-bot shaka-bot added this to the v4.14 milestone Feb 4, 2025
@avelad avelad added the component: CMCD The issue involves CMCD specifically label Feb 4, 2025
@avelad avelad added the priority: P2 Smaller impact or easy workaround label Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: CMCD The issue involves CMCD specifically priority: P2 Smaller impact or easy workaround type: bug Something isn't working correctly
Projects
None yet
3 participants