-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better API for the track variants #758
Comments
Text tracks are separate from variants. Look for type == 'text'. The combined codecs in variants is another side-effect of our HLS support, but I think we can probably change it. Would you prefer to see audioCodec and videoCodec in separate fields? |
Hi Joey! Thanks for the type clarification. We need to do the simple audio detection. If there aren't any audio tracks, we could somehow let users know about it. |
Counting audio channels in DASH is complex. There is another issue filled for that already (#424). I'll update that issue soon with more details. I'm fairly sure we can split up the codecs, though. |
This is now fixed in |
The audio and video codecs were combined in Track, so it's hard to detect whether the track variant has video or audio track. Changing the combined codec to two separate fields. Closes #758. Change-Id: I9fbd0b85830cac306dc09db2d71cf96f77146cbe
Cherry-picked to v2.1.1. |
I would like to know easily, whether the track variants has video, audio or subtitle track. Now I have to check for a comma inside codecs. Here is sample output from the method getVariantTracks():
{"id":7,"active":false,"type":"variant","bandwidth":1799135,"language":"en","kind":null,"width":1920,"height":1080,"frameRate":23.976023976023978,"mimeType":"video/mp4","codecs":"avc1.640032, mp4a.40.2","primary":false}
It would be nice to have properties grouped instead of merged.
Btw, is it necessary to output constant property type = 'variant'?
Thanks!
The text was updated successfully, but these errors were encountered: