Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Difference accessing methods on compiled vs uncompiled player? #7416

Closed
fredrik-telia opened this issue Oct 11, 2024 · 4 comments · Fixed by #7418 or #7257
Closed

Difference accessing methods on compiled vs uncompiled player? #7416

fredrik-telia opened this issue Oct 11, 2024 · 4 comments · Fixed by #7418 or #7257
Labels
status: archived Archived and locked; will not be updated type: question A question from the community

Comments

@fredrik-telia
Copy link
Contributor

fredrik-telia commented Oct 11, 2024

Have you read the Tutorials?
Yes

Have you read the FAQ and checked for duplicate open issues?
Yes

What version of Shaka Player are you using?
4.11.7

What browser and OS are you using?
Mac/Chrome

Please ask your question
Ok, maybe I'm misunderstanding something here, I'm trying to access the new getFetchedPlaybackInfo()-method, using version 4.11.7, but I can't.

I decided to check the demo app, and using the compiled (release) version I get:
Uncaught TypeError: p.getFetchedPlaybackInfo is not a function
when running the following in the console:

p = new shaka.Player()
p.getFetchedPlaybackInfo()

However, using either the debug version or the uncompiled version, it works as expected:

{video: null, audio: null, text: null}

tl;dr:
using the debug or uncompiled version of the demo player let's me create a new shaka player and access getFetchedPlaybackInfo(), but using the compiled version I cannot.

@fredrik-telia fredrik-telia added the type: question A question from the community label Oct 11, 2024
@Iragne
Copy link
Contributor

Iragne commented Oct 11, 2024

Hello if i'm not wrong this function is not export to the public interface. that is why you can have it in debug and not in compile version
we should have * @export on it
or maybe i miss also something

@joeyparrish
Copy link
Member

This was added in #7074. Based on the details in that PR (externs defined for the return value, added to method list in a cast test), I think it was intended to be exported. Adding the @export annotation should fix it.

@Iragne
Copy link
Contributor

Iragne commented Oct 11, 2024

I just push the PR ;) @fredrik-telia

@fredrik-telia
Copy link
Contributor Author

I just push the PR ;) @fredrik-telia

Excellent, thank you @Iragne !

avelad pushed a commit that referenced this issue Oct 18, 2024
@shaka-bot shaka-bot added the status: archived Archived and locked; will not be updated label Dec 10, 2024
@shaka-project shaka-project locked as resolved and limited conversation to collaborators Dec 10, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
status: archived Archived and locked; will not be updated type: question A question from the community
Projects
None yet
4 participants