-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mouse cursor only hidden when placed at the center of the video player #7394
Comments
Great find! This probably has to do with which elements get mouse interactions, who receives mouseover events, how the timer to hide the mouse is started, etc. |
After commenting out the cursor tracking everything works fine. So you're right. |
@FiberOnePL which lines did you comment out? |
Would you please consider sending a PR? |
The cursor is also not hidden along with the rest of the UI if it's placed over other elements such as the center play button, if enabled, or the progress bar area. |
When the cursor is placed over the big play button, the DevTools debugger does break if the breakpoint is set to the line that sets the cursor style to 'none' , but the cursor does not disappear. |
when hiding and showing the cursor partially fixes shaka-project#7394
when hiding and showing the cursor partially fixes shaka-project#7394
Can you create a PR with your change? Thanks! |
Yes, the problem is caused by cursor tracking |
Recursively changing the cursor feels hacky. Shouldn't elements below the container inherit the cursor style instead? |
Hrm... then maybe we should adjust those as well. Maybe some of them are not needed? |
When playing a video, the cursor remains visible when being placed on the left or the right side of the video player, it is hidden when being place in the center of the video player. These positions seem to be related to the div.shake-rewind-container and div.shaka-fast-forward-container seen in the (edited) screenshot (the green area is the one where the cursor is hidden).
![337990817-874fa1af-40d9-4b98-ab6a-48948e506a1f](https://private-user-images.githubusercontent.com/4758817/373410401-aacbda46-8a38-4c63-8c71-82e6eb7e000b.jpg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkxNTE0NDEsIm5iZiI6MTczOTE1MTE0MSwicGF0aCI6Ii80NzU4ODE3LzM3MzQxMDQwMS1hYWNiZGE0Ni04YTM4LTRjNjMtOGM3MS04MmU2ZWI3ZTAwMGIuanBnP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIxMCUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMTBUMDEzMjIxWiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9ZDM0ZTA4YzliZjA5YjM4MGVhNmJiODQ4ZTdhYjM2Y2I4YjI1ZmI0NDNlNTIxMmQ4M2M5NDYyMTE3ZDc0NzkwOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.IHZg5ZPCFAwy-kcF4OxjIj5UEqE-xalevWEEAFdVGI0)
The text was updated successfully, but these errors were encountered: