Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduces syslog priority of common usage events #29

Merged
merged 1 commit into from
Aug 5, 2016

Conversation

sophie-h
Copy link
Contributor

@sophie-h sophie-h commented Aug 4, 2016

  • Log INFO instead of ERR on su missing-user
  • Log NOTICE/WARN instead of ERR on pam_authenticate failure (wrong password for example)

This PR is part of an ongoing effort to make syslog entries more expressive in Debian. Similar issues in important components like OpenSSH and PAM were addressed upstream.

- Log INFO instead of ERR on `su missing-user`
- Log NOTICE/WARN instead of ERR on pam_authenticate failure (wrong password for example)
@hallyn
Copy link
Member

hallyn commented Aug 5, 2016

Seems ok, but do you think there might be people grepping logs specifically for those levels expecting to see for instance wrong password messages?

@sophie-h
Copy link
Contributor Author

sophie-h commented Aug 5, 2016

Are you asking why this change is useful? The reason is that we believe that level ERR should be reserved for messages that can be reported to system administrators automatically. There is little reason that the su errors imply that there is any action needed. (Usually it's just a misspelling by a admin anyway). I am addressing those specific problems because they became annoying on our systems.

If you are asking for backward compatibility: Log levels seem to have been used rarely before journald. Because of that, levels have been assigned carelessly in the past. There will be many other level changes in stretch.

@hallyn hallyn merged commit 5b017af into shadow-maint:master Aug 5, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants