Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cli): Ensure .scss files are considered in getTailwindCssFile #4797

Merged
merged 2 commits into from
Sep 15, 2024
Merged

fix(cli): Ensure .scss files are considered in getTailwindCssFile #4797

merged 2 commits into from
Sep 15, 2024

Conversation

Wiper-R
Copy link
Contributor

@Wiper-R Wiper-R commented Sep 10, 2024

Fixes #4689

  • Updated getTailwindCssFile function to include .scss files when checking for Tailwind CSS configuration.
  • This change ensures that .scss files are properly identified and handled, improving compatibility with projects using SCSS.

- Updated getTailwindCssFile function to include .scss files when checking for Tailwind CSS configuration.
- This change ensures that .scss files are properly identified and handled, improving compatibility with projects using SCSS.
Copy link

vercel bot commented Sep 10, 2024

@Wiper-R is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. Thank you.

@shadcn shadcn added enhancement New feature or request area: shadcn labels Sep 15, 2024
@shadcn shadcn merged commit 207b69f into shadcn-ui:main Sep 15, 2024
4 of 5 checks passed
@shadcn
Copy link
Collaborator

shadcn commented Sep 15, 2024

@Wiper-R I just noticed that you made the change in cli and not the new package shadcn. Can you create a new PR please?

@Wiper-R
Copy link
Contributor Author

Wiper-R commented Sep 16, 2024

@Wiper-R I just noticed that you made the change in cli and not the new package shadcn. Can you create a new PR please?

Yeah, here #4866

niktekusho pushed a commit to niktekusho/shadcnui that referenced this pull request Nov 21, 2024
…adcn-ui#4797)

* fix(cli): Ensure .scss files are considered in getTailwindCssFile

- Updated getTailwindCssFile function to include .scss files when checking for Tailwind CSS configuration.
- This change ensures that .scss files are properly identified and handled, improving compatibility with projects using SCSS.

* chore: add changeset

---------

Co-authored-by: shadcn <m@shadcn.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: shadcn enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug]: Having global.scss instead of global.css, doesn't init shadncn
2 participants