Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement plot(df[, x, y]) and add CI #6

Merged
merged 6 commits into from
Jun 12, 2019
Merged

Implement plot(df[, x, y]) and add CI #6

merged 6 commits into from
Jun 12, 2019

Conversation

dovahcrow
Copy link
Member

No description provided.

@dovahcrow
Copy link
Member Author

First, the commit "Delete EDA_plot#2.py" need to be squashed.

dovahcrow
dovahcrow commented May 29, 2019
View reviewed changes
Copy link
Member Author

@dovahcrow dovahcrow left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the files should be more informative, maybe you can name them with respect to their functionality.
Additionally, the tests/style/type checks should be passed.

dataprep/eda/EDA_plot.py Outdated Show resolved Hide resolved
dataprep/eda/EDA_plot.py Outdated Show resolved Hide resolved
dataprep/eda/EDA_plot.py Outdated Show resolved Hide resolved
dataprep/eda/EDA_plot_2.py Outdated Show resolved Hide resolved
@dovahcrow dovahcrow force-pushed the dataprep branch 2 times, most recently from b917805 to 55685ef Compare May 31, 2019 02:09
jnwang
jnwang reviewed Jun 1, 2019
View reviewed changes
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
shub970 added a commit that referenced this pull request Jun 3, 2019
@shub970
refactor(eda.plot) : Code refactoring
449e442 
code refactoring #6

Signed-off-by: shub970 <laddha.shubham97@gmail.com>
jinglinpeng
jinglinpeng reviewed Jun 5, 2019
View reviewed changes
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dovahcrow
dovahcrow commented Jun 6, 2019
View reviewed changes
Copy link
Member Author

@dovahcrow dovahcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After these minor fixes are done I think it can be committed.

dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
dovahcrow
dovahcrow commented Jun 8, 2019
View reviewed changes
Copy link
Member Author

@dovahcrow dovahcrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left more comments

mypy.ini Show resolved Hide resolved
dataprep/eda/eda_plot.py Outdated Show resolved Hide resolved
@dovahcrow dovahcrow force-pushed the dataprep branch 11 times, most recently from 20b9d71 to 1d07e13 Compare June 12, 2019 20:42
@dovahcrow dovahcrow changed the title WIP: Implement plot(df[, x, y]) and add CI Implement plot(df[, x, y]) and add CI Jun 12, 2019
@dovahcrow dovahcrow merged commit 3020453 into master Jun 12, 2019
@dovahcrow dovahcrow deleted the dataprep branch July 6, 2019 23:18
dovahcrow added a commit that referenced this pull request May 29, 2020
@dovahcrow
Merge pull request #6 from sfu-db/dataprep
76373b2 
Implement `plot(df[, x, y])` and add CI
fatbuddy added a commit to fatbuddy/dataprep that referenced this pull request Feb 10, 2024
@fatbuddy
Windows dependency fix sfu-db#6
426f182
fatbuddy added a commit to fatbuddy/dataprep that referenced this pull request Mar 15, 2024
@fatbuddy
Support on Python 3.12.x sfu-db#6
c5ecbfb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnwang jnwang jnwang left review comments

@shub970 shub970 shub970 left review comments

@jinglinpeng jinglinpeng jinglinpeng approved these changes

Assignees

@dovahcrow dovahcrow

@jinglinpeng jinglinpeng

@shub970 shub970

Labels
module: EDA
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dovahcrow @jnwang @jinglinpeng @shub970