Resolution of any value error within [student_id] - Issue #334 #351
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
> > Co-authored-by: Yun Whitman <savannahwhitman1@gmail.com>
1 task
> > Co-authored-by: Yun Whitman <savannahwhitman1@gmail.com>
1 task
KCCPMG
approved these changes
Jul 22, 2024
There was a problem hiding this comment.
Looks good. I linked this PR to issue 334, but when I was looking for it, I didn't actually see the original error that #334 was referencing- maybe it was cleaned up in an earlier revision? At any rate I think this is good to go assuming there are no merge issues.
src/pages/students/[student_id].tsx
Outdated
| import $StudentPage from "../../styles/StudentPage.module.css"; | ||
|
|
||
| import * as React from "react"; | ||
| import Typography from "@mui/material/Typography"; | ||
|
|
||
| // test comment |
There was a problem hiding this comment.
Probably don't need this anymore?
There was a problem hiding this comment.
Thanks Connor! deleted this extraneous comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See issue here: #334
Import of the custom/project Modal component was not occurring.
Note that the staff page does not utilize the same Modal, so the reference doesn't need updates.
Co-authored-by: Yun Whitman savannahwhitman1@gmail.com