fix: print error on init when cannot find a package.json #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmmm... Something's busted with the build. It looks unrelated so I'll merge this, but we wont get a release until that's fixed and I wont have time to work on it. |
|
Looks like my change caused the tests to fail... I'll look. |
|
Yeah, my bad... a last minute change added a bug. New PR coming. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
If a user runs
nps initin an empty directory with no existingpackage.jsonthe command fails with a non-user friendly error.How:
If this "error" is encountered print a friendly error and exit.
Comments:
Instead of exiting out
nps initcould continue without any package.json scripts and use the local directory as the package-scripts.js path.