Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(help command): Display the 'default' script when using the 'help' command #131

Merged
merged 2 commits into from
Apr 15, 2017

Conversation

imwiss
Copy link
Contributor

@imwiss imwiss commented Apr 14, 2017

Display the 'default' script when using the 'help' command alongside all the other scripts.

Issue #130

What: Display the 'default' script when using the 'help' command alongside all the other scripts.

Why: Hotfix for issue #130

PS: when using npm start commit, the linter is modifying lines that were untouched prior to the commit.

… command

Display the 'default' script when using the 'help' command alongside all the other scripts.

Issue sezna#130
@codecov-io
Copy link

codecov-io commented Apr 14, 2017

Codecov Report

Merging #131 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@          Coverage Diff          @@
##           master   #131   +/-   ##
=====================================
  Coverage     100%   100%           
=====================================
  Files          10     10           
  Lines         286    288    +2     
=====================================
+ Hits          286    288    +2
Impacted Files Coverage Δ
src/bin-utils/index.js 100% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d81c793...6aa37e6. Read the comment docs.

Copy link
Collaborator

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you so much! This look awesome. Just one thing if you want to do it.

"name": "Wissam Abirached",
"avatar_url": "https://avatars2.githubusercontent.com/u/3534924?v=3",
"profile": "https://designingforscale.com",
"contributions": []
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you want to add code and test to this? Then run npm start generateContributors to regenerate the table 👍

@kentcdodds
Copy link
Collaborator

PS: when using npm start commit, the linter is modifying lines that were untouched prior to the commit.

Yeah, sorry about that :)

@imwiss
Copy link
Contributor Author

imwiss commented Apr 14, 2017

My pleasure, Kent! Glad to help.

@kentcdodds
Copy link
Collaborator

Thank you! This is great!

@kentcdodds kentcdodds merged commit 7a7716d into sezna:master Apr 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants