impl Borrow<[u8]> for Tendril #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes using a Tendril as a HashMap key a little more palatable. Sadly, str and [u8] hash differently at present, so we shouldn’t implement Borrow<str> for StrTendril. An alternative would be making the Hash implementations for Tendril<F> manual and making Tendril<UTF8> use the str Hash implementation and the rest use the [u8] one. See also rust-lang/rust#27108 which deals with fixing the underlying problem of the differing Hash implementations.
|
It occurs to me just now that I should for maximal assurance add a test of this, using tendrils as HashMap keys. I’ll probably do this on Monday; just now I’m going to bed—genuinely forgetting to add a relevant test before making such a PR shows I need it! |
Add a Borrow test.
|
I’ve now added a basic test of using tendrils as HashMap keys. |
|
Looks good, thanks! |
SimonSapin
added a commit
that referenced
this pull request
Jul 21, 2015
impl Borrow<[u8]> for Tendril
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes using a Tendril as a HashMap key a little more palatable. Sadly,
strand[u8]hash differently at present, so we shouldn’t implementBorrow<str>forStrTendril. An alternative would be making theHashimplementations forTendril<F>manual and makingTendril<UTF8>use thestrHashimplementation and the rest use the[u8]one.See also rust-lang/rust#27108 which deals with fixing the underlying problem of the differing
Hashimplementations.