This repository has been archived by the owner on Nov 12, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 117
Update SpiderMonkey to 97 #556
Draft
CYBAI
wants to merge
2
commits into
servo:master
Choose a base branch
from
CYBAI:smup-97
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CYBAI
commented
Feb 21, 2022
@@ -1062,13 +1087,13 @@ CallUnbarrieredObjectTracer(JSTracer* trc, JSObject** objp, const char* name) | |||
void | |||
CallObjectRootTracer(JSTracer* trc, JSObject** objp, const char* name) | |||
{ | |||
JS::UnsafeTraceRoot(trc, objp, name); | |||
JS::TraceRoot(trc, objp, name); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This method was renamed at https://bugzilla.mozilla.org/show_bug.cgi?id=1744059.
4 tasks
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Mar 17, 2022
[WIP] Upgrade to SpiderMonkey 97 This should be merged after servo/mozjs#295 and servo/rust-mozjs#556 merged. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [x] There are tests for these changes (We need to confirm this smup will break or fix which tests)
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Apr 15, 2022
[WIP] Upgrade to SpiderMonkey 97 This should be merged after servo/mozjs#295 and servo/rust-mozjs#556 merged. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [x] There are tests for these changes (We need to confirm this smup will break or fix which tests)
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Apr 24, 2022
[WIP] Upgrade to SpiderMonkey 97 This should be merged after servo/mozjs#295 and servo/rust-mozjs#556 merged. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [x] There are tests for these changes (We need to confirm this smup will break or fix which tests)
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Aug 29, 2022
[WIP] Upgrade to SpiderMonkey 97 This should be merged after servo/mozjs#295 and servo/rust-mozjs#556 merged. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [x] There are tests for these changes (We need to confirm this smup will break or fix which tests)
bors-servo
added a commit
to servo/servo
that referenced
this pull request
Aug 30, 2022
[WIP] Upgrade to SpiderMonkey 97 This should be merged after servo/mozjs#295 and servo/rust-mozjs#556 merged. --- - [x] `./mach build -d` does not report any errors - [x] `./mach test-tidy` does not report any errors - [ ] These changes fix #___ (GitHub issue number if applicable) - [x] There are tests for these changes (We need to confirm this smup will break or fix which tests)
☔ The latest upstream changes (presumably #562) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mozjs PR is at servo/mozjs#295
Cargo.toml