Treat url(<string>) as a normal functions, per spec change. #90
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Only unquoted URLs are special tokens now. Use `Parser::expect_url`. This is a [breaking-change]. The version number was incremented accordingly. This change will help with servo/servo#7767
9201f47 to
3e2e0b5
Compare
|
Reviewed 5 of 5 files at r1. Comments from the review on Reviewable.io |
|
@bors-servo r+ |
|
📌 Commit 3e2e0b5 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Oct 9, 2015
Treat url(<string>) as a normal functions, per spec change. Only unquoted URLs are special tokens now. Use `Parser::expect_url`. This is a [breaking-change]. The version number was incremented accordingly. This change will help with servo/servo#7767 This triggers rust-lang/rust#28934 and fails to build in the current Rust nightly, but works fine in the Rust version that Servo currently use. Hopefully that rustc bug will be fixed before we need to upgrade Rust in Servo. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/90) <!-- Reviewable:end -->
|
💔 Test failed - travis |
|
We'll need to disable the nightly channel in Travis temporarily, or pin it to a specific nightly. |
|
Let’s wait and see if I want to land the corresponding Servo change before the rustc bug is fixed. |
1 task
|
@bors-servo r=mbrubeck |
|
The Rust bug is fixed in nightly, but beta shipped with it: rust-lang/rust#29188 (comment) |
|
@bors-servo retry |
|
@bors-servo: r=mbrubeck |
1 similar comment
|
@bors-servo: r=mbrubeck |
|
📌 Commit fa477fd has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Nov 2, 2015
Treat url(<string>) as a normal functions, per spec change. Only unquoted URLs are special tokens now. Use `Parser::expect_url`. This is a [breaking-change]. The version number was incremented accordingly. This change will help with servo/servo#7767 This triggers rust-lang/rust#28934 and fails to build in the current Rust nightly, but works fine in the Rust version that Servo currently use. Hopefully that rustc bug will be fixed before we need to upgrade Rust in Servo. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/90) <!-- Reviewable:end -->
|
💔 Test failed - travis |
|
Failed on the beta compiler as expected. |
|
@bors-servo retry rust-lang/rust#29188 has been backported to 1.5.0-beta.3: rust-lang/rust#29592 |
bors-servo
pushed a commit
that referenced
this pull request
Nov 5, 2015
Treat url(<string>) as a normal functions, per spec change. Only unquoted URLs are special tokens now. Use `Parser::expect_url`. This is a [breaking-change]. The version number was incremented accordingly. This change will help with servo/servo#7767 This triggers rust-lang/rust#28934 and fails to build in the current Rust nightly, but works fine in the Rust version that Servo currently use. Hopefully that rustc bug will be fixed before we need to upgrade Rust in Servo. r? @mbrubeck <!-- Reviewable:start --> [<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/rust-cssparser/90) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Only unquoted URLs are special tokens now. Use
Parser::expect_url.This is a [breaking-change]. The version number was incremented accordingly.
This change will help with servo/servo#7767
This triggers rust-lang/rust#28934 and fails to build in the current Rust nightly, but works fine in the Rust version that Servo currently use. Hopefully that rustc bug will be fixed before we need to upgrade Rust in Servo.
r? @mbrubeck