Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added Traceable for PropertyDescriptor #430

Merged
merged 4 commits into from
Dec 3, 2023

Conversation

redfire75369
Copy link
Contributor

No description provided.

@sagudev
Copy link
Member

sagudev commented Nov 28, 2023

@jdm
Copy link
Member

jdm commented Nov 28, 2023

error[E0412]: cannot find type `JSVal` in this scope
   --> mozjs/src/gc/trace.rs:127:62
    |
127 |         CallValueTracer(trc, &self.value_ as *const _ as *mut Heap<JSVal>, c_str!("object"));
    |                                                                    ^^^^^ not found in this scope
    |
help: consider importing one of these items
    |
1   + use crate::jsval::JSVal;
    |
1   + use mozjs_sys::jsval::JSVal;
    |

@redfire75369 redfire75369 force-pushed the trace/property-descriptor branch from d359536 to d9c9976 Compare November 29, 2023 16:36
@jdm jdm enabled auto-merge December 1, 2023 16:10
auto-merge was automatically disabled December 1, 2023 20:02

Head branch was pushed to by a user without write access

@jdm jdm enabled auto-merge December 1, 2023 20:12
@redfire75369
Copy link
Contributor Author

redfire75369 commented Dec 2, 2023

The error on debug windows arm64 seems spurious? There's no error and seemingly a segfault in rustc?
Could you perhaps try rerunning the check?

@jdm jdm added this pull request to the merge queue Dec 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 2, 2023
@sagudev
Copy link
Member

sagudev commented Dec 2, 2023

The error on debug windows arm64 seems spurious? There's no error and seemingly a segfault in rustc? Could you perhaps try rerunning the check?

I also managed to get this on main: https://github.com/servo/mozjs/actions/runs/7068898831

@redfire75369
Copy link
Contributor Author

The most likely cause seems to be rust 1.74, although there's a chance its from the upgrade to VS 17.8.34316.

@sagudev
Copy link
Member

sagudev commented Dec 2, 2023

I was diffing from last know working build and OS image and rust version is the same.

@redfire75369
Copy link
Contributor Author

In that case, this certainly seems spurious.

@sagudev
Copy link
Member

sagudev commented Dec 2, 2023

50% of manually dispatched runs failed

@sagudev
Copy link
Member

sagudev commented Dec 2, 2023

Or maybe it is rust problem after all: rust-lang/rust#118462

@jdm jdm added this pull request to the merge queue Dec 3, 2023
Merged via the queue into servo:main with commit c7fb1b8 Dec 3, 2023
@redfire75369 redfire75369 deleted the trace/property-descriptor branch December 6, 2023 16:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants