Remove incorrect unsafe impl Send for Token { }
#253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let’s batch this with the next breaking change… |
|
☔ The latest upstream changes (presumably #255) made this pull request unmergeable. Please resolve the merge conflicts. |
Token contains StrTendril, which is not Send because it contains a shared reference to a `Cell<usize>` for reference-counting. Refactor test harness to not need Send.
|
@bors-servo r+ |
|
📌 Commit 2341b39 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
Mar 15, 2017
Remove incorrect `unsafe impl Send for Token { }`
Token contains StrTendril, which is not Send because it contains a shared reference to a `Cell<usize>` for reference-counting.
Refactor test harness to not need Send.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/html5ever/253)
<!-- Reviewable:end -->
|
☀️ Test successful - status-travis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Token contains StrTendril, which is not Send because it contains a shared reference to a
Cell<usize>for reference-counting.Refactor test harness to not need Send.
This change is