This repository was archived by the owner on Jul 10, 2023. It is now read-only.
Add bindings to NSInsetRect and NSRectToCGRect, and make various geometry types copyable.
#129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geometry types copyable.
pcwalton
added a commit
to pcwalton/glutin
that referenced
this pull request
May 27, 2016
specify that only the corners of a window can be transparent. By doing this, we significantly improve performance by allowing the window server to perform occlusion culling under most of the window. This patch relies on the private `CGSRegion` and the private `-[NSCGSWindow setOpaqueRegion:]` APIs. Requires servo/core-graphics-rs#50 and servo/cocoa-rs#129.
|
@bors-servo r+
|
|
📌 Commit 37b5ce6 has been approved by |
bors-servo
pushed a commit
that referenced
this pull request
May 27, 2016
Add bindings to `NSInsetRect` and `NSRectToCGRect`, and make various geometry types copyable. r? @metajack <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/cocoa-rs/129) <!-- Reviewable:end -->
|
☀️ Test successful - travis |
pcwalton
added a commit
to pcwalton/glutin
that referenced
this pull request
May 31, 2016
specify that only the corners of a window can be transparent. By doing this, we significantly improve performance by allowing the window server to perform occlusion culling under most of the window. This patch relies on the private `CGSRegion` and the private `-[NSCGSWindow setOpaqueRegion:]` APIs. Requires servo/core-graphics-rs#50 and servo/cocoa-rs#129.
bors-servo
pushed a commit
to servo/glutin
that referenced
this pull request
May 31, 2016
…etajack cocoa: Add a new platform-specific API that allows library consumers to specify that only the corners of a window can be transparent. By doing this, we significantly improve performance by allowing the window server to perform occlusion culling under most of the window. This patch relies on the private `CGSRegion` and the private `-[NSCGSWindow setOpaqueRegion:]` APIs. Requires servo/core-graphics-rs#50 and servo/cocoa-rs#129. r? @metajack <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/94) <!-- Reviewable:end -->
pcwalton
added a commit
to pcwalton/glutin
that referenced
this pull request
Jun 2, 2016
specify that only the corners of a window can be transparent. By doing this, we significantly improve performance by allowing the window server to perform occlusion culling under most of the window. This patch relies on the private `CGSRegion` and the private `-[NSCGSWindow setOpaqueRegion:]` APIs. Requires servo/core-graphics-rs#50 and servo/cocoa-rs#129.
bors-servo
pushed a commit
to servo/glutin
that referenced
this pull request
Jun 2, 2016
…etajack cocoa: Add a new platform-specific API that allows library consumers to specify that only the corners of a window can be transparent. By doing this, we significantly improve performance by allowing the window server to perform occlusion culling under most of the window. This patch relies on the private `CGSRegion` and the private `-[NSCGSWindow setOpaqueRegion:]` APIs. Requires servo/core-graphics-rs#50 and servo/cocoa-rs#129. r? @metajack <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/94) <!-- Reviewable:end -->
pcwalton
added a commit
to pcwalton/glutin
that referenced
this pull request
Jun 2, 2016
specify that only the corners of a window can be transparent. By doing this, we significantly improve performance by allowing the window server to perform occlusion culling under most of the window. This patch relies on the private `CGSRegion` and the private `-[NSCGSWindow setOpaqueRegion:]` APIs. Requires servo/core-graphics-rs#50 and servo/cocoa-rs#129.
bors-servo
pushed a commit
to servo/glutin
that referenced
this pull request
Jun 2, 2016
…etajack cocoa: Add a new platform-specific API that allows library consumers to specify that only the corners of a window can be transparent. By doing this, we significantly improve performance by allowing the window server to perform occlusion culling under most of the window. This patch relies on the private `CGSRegion` and the private `-[NSCGSWindow setOpaqueRegion:]` APIs. Requires servo/core-graphics-rs#50 and servo/cocoa-rs#129. r? @metajack <!-- Reviewable:start --> --- This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/glutin/94) <!-- Reviewable:end -->
emilio
pushed a commit
to emilio/glutin
that referenced
this pull request
Jul 6, 2016
specify that only the corners of a window can be transparent. By doing this, we significantly improve performance by allowing the window server to perform occlusion culling under most of the window. This patch relies on the private `CGSRegion` and the private `-[NSCGSWindow setOpaqueRegion:]` APIs. Requires servo/core-graphics-rs#50 and servo/cocoa-rs#129.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? @metajack
This change is