Skip to content
This repository has been archived by the owner on Jan 28, 2025. It is now read-only.

fix: only delete the sqs queue if it already exists in the state #1147

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

kirkness
Copy link
Collaborator

@kirkness kirkness commented Jun 2, 2021

Initial issue: #1098 (comment)

@codecov
Copy link

codecov bot commented Jun 2, 2021

Codecov Report

Merging #1147 (8d73c44) into master (fcfa05c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1147   +/-   ##
=======================================
  Coverage   82.99%   82.99%           
=======================================
  Files          95       95           
  Lines        3222     3223    +1     
  Branches      935      936    +1     
=======================================
+ Hits         2674     2675    +1     
  Misses        485      485           
  Partials       63       63           
Impacted Files Coverage Δ
...ckages/serverless-components/aws-sqs/serverless.js 96.42% <100.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcfa05c...8d73c44. Read the comment docs.

@dphang
Copy link
Collaborator

dphang commented Jun 2, 2021

Thanks! Looks fine, I can merge it now but I'm on vacation until next weekend, so won't be able to publish until then

@dphang dphang merged commit c072437 into master Jun 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the fix/only-delete-queue-if-exists branch June 2, 2021 17:13
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants