Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ENH] Simplify L7 footprint #198

Closed
remi-braun opened this issue Jan 10, 2025 · 2 comments
Closed

[ENH] Simplify L7 footprint #198

remi-braun opened this issue Jan 10, 2025 · 2 comments
Labels
enhancement New feature or request

Comments

@remi-braun
Copy link
Member

Right now, the L7 footprint is degenerated because of all the nodata strips.
Clean it using the minimum rotated rectangle containing the computed footprint.

See https://shapely.readthedocs.io/en/stable/manual.html#object.minimum_rotated_rectangle
@remi-braun remi-braun added enhancement New feature or request 0.22.0 For version 0.22.0 labels Jan 10, 2025
@remi-braun
Copy link
Member Author

remi-braun commented Feb 13, 2025 •
edited
Loading

Using the minimum rotated rectangle is not perfect as the corners should be right-angled. (And minimum rotated losange doesn't exist 😆), but is better. At least the footprint has 4 corners.

Image

@remi-braun
Copy link
Member Author

Simplify it to 4 pixels works better (chosen solution):

Image

@remi-braun remi-braun changed the title [ENH] Use minimum rotated rectangle to have simplify L7 footprint [ENH] Simplify L7 footprint Feb 14, 2025
remi-braun added a commit that referenced this issue Feb 14, 2025
@remi-braun
FIX: Simplify L7 footprint #198
80a816f
@remi-braun remi-braun removed the 0.22.0 For version 0.22.0 label Feb 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@remi-braun