Custom env variables #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nblumhardt
reviewed
Jan 3, 2023
|
|
||
| if (string.IsNullOrWhiteSpace(environmentVariableValue)) | ||
| { | ||
| environmentVariableValue = "<Empty>"; |
There was a problem hiding this comment.
Any reason for a placeholder here? It should be fine to create a property with an empty or null value.
There was a problem hiding this comment.
Not really actually, I guess I was just "tainted" by default value of EnvironmentName (production) and that it can sometimes be nice during debugging to see if your value is picked up or not but for me this is no big question. Codewise it's cleaner to just remove it.
0cc353d to
402d17a
Compare
|
Great, thanks! 👍 I'll keep an eye on CI/publishing; a |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This goes back a few years to #24 and #15. Hopefully we can get this into place now.