Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the test SDK and xunit packages in the test project #40

Merged
merged 3 commits into from
Feb 4, 2021

Conversation

Numpsy
Copy link
Member

@Numpsy Numpsy commented Oct 28, 2020

When I grabbed the test project to use as a base for some Process enricher tests I noticed that it's using beta and preview test packages. This is just to update it to release package versions.

@Numpsy
Copy link
Member Author

Numpsy commented Oct 28, 2020

Or not, as it doesn't seem to like running the tests as .NET Core 1.0 :-(

Q. - does it need to test with netcoreapp1.0 now, or could that be replaced with one or more newer versions?

@nblumhardt
Copy link
Member

I think it would be fair to bump up the major version of this package, and drop support for the netstandard1.x/netcoreapp1.x targets 👍

Copy link
Member

@nblumhardt nblumhardt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@0xced 0xced mentioned this pull request Feb 3, 2021
@nblumhardt nblumhardt merged commit 9fc39af into serilog:dev Feb 4, 2021
@Numpsy Numpsy deleted the rw/bump_test_packages branch February 4, 2021 10:28
@nblumhardt nblumhardt mentioned this pull request Aug 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants