This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Use apikey to access elastic search #545
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use apikey to access elasticsearch
mivano
reviewed
Jun 7, 2023
src/Serilog.Sinks.Elasticsearch/Sinks/ElasticSearch/ElasticsearchSinkOptions.cs
Show resolved
Hide resolved
mivano
reviewed
Jun 7, 2023
src/Serilog.Sinks.Elasticsearch/Sinks/ElasticSearch/ElasticsearchSinkOptions.cs
Outdated
Show resolved
Hide resolved
|
Thanks for the PR. Some minor suggestions if you please. |
|
changed comment, check please |
for integration test
For integration test
|
Is any other issue in the PR? |
|
No other issue, just slipped my attention. Thanks for the nudge and the PR! I will prepare a release. |
|
@qgbo version 9.0.2 contains this addition. Thanks for the PR! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a property (Apikey) in Update ElasticsearchSinkOptions.cs.
You can assign it some vaule.
Then you can access your elasticsearch using the apikey, instead user/password.
In some cases, api key is a more appropriate choice.
You can create the api key, in kibana:
POST /security/api_key { "name": "aaa-apikeys", "role_descriptors": { "abc-shared-application": { "cluster": [ "all" ], "index": [ { "names": [ "abc_share*" ], "privileges": [ "all" ] } ] } } }then you can get the apikey coded by base64
it like this:
aFlBbDVvY0JOblduWHdpZnNLOUk6cEt2Y01tYVlRQ3FsWlF0MVVjRkN034==For more detail about apiKey, see: https://www.elastic.co/guide/en/apm/server/7.15/api-key.html