This repository has been archived by the owner on Jun 1, 2024. It is now read-only.
Override type name if specified #365
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes a regression introduced in serilog-contrib#356 We should override the TypeName if it's specified. Note that there are different defaults depending on how the options are created. - Created from configuration it defaults to `logevent` - Created from code it defaults to `_doc`
|
Thanks for looking into this and providing a fix! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a regression introduced in #356
We should override the TypeName if it's specified.
Note that there are different defaults depending
on how the options are created.
logevent_docWhat issue does this PR address?
#364
Does this PR introduce a breaking change?
No
Please check if the PR fulfills these requirements