Remove some chrono #933
Merged
Remove some chrono #933
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
requested changes
Aug 18, 2020
src/internal/timer.rs
Outdated
| duration: Duration, | ||
| } | ||
|
|
||
| impl Timer { | ||
| /// construct timer, initially set and due `duration_in_ms` in the future |
There was a problem hiding this comment.
Doc-strings should be written as proper sentences. They should start with an uppercase letter, and end with a full stop.
Suggested change
| /// construct timer, initially set and due `duration_in_ms` in the future | |
| /// Construct a `Timer`, which is initially set to expire in due `duration_in_ms` time from the current instant. |
src/internal/timer.rs
Outdated
| duration, | ||
| } | ||
| } | ||
|
|
||
| /// block until next due time resetting afterwards |
There was a problem hiding this comment.
Suggested change
| /// block until next due time resetting afterwards | |
| /// Block until the due time. The timer will be reset afterwards. |
src/internal/timer.rs
Outdated
| } | ||
|
|
||
| /// returns true and resets the timer if due |
There was a problem hiding this comment.
Suggested change
| /// returns true and resets the timer if due | |
| /// Returns a boolean indicating whether the timer has expired. the timer will also be reset if it has. |
src/internal/timer.rs
Outdated
| true | ||
| } else { | ||
| false | ||
| } | ||
| } | ||
|
|
||
| pub fn reset(&mut self) { self.due = Utc::now() + self.duration; } | ||
| /// reset timer to be 1 duration after previous due time |
There was a problem hiding this comment.
Suggested change
| /// reset timer to be 1 duration after previous due time | |
| /// Resets the timer by incrementing the due time using the duration that was passed upon construction of the timer. |
src/internal/timer.rs
Outdated
| self.due += self.duration | ||
| } | ||
|
|
||
| /// reset timer to be 1 duration from **now** |
There was a problem hiding this comment.
Suggested change
| /// reset timer to be 1 duration from **now** | |
| /// Resets the timer by restarting from the current instant and setting its due time to the duration that was passed upon construction. This has the same effect as constructing a new `Timer`. |
d20d110 to
0ceffb2
Compare
arqunis
approved these changes
Aug 20, 2020
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Nov 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is only about changes that don't affect public API