Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed unrecognised_command() not working if the last group added has prefixes. #867

Merged
merged 2 commits into from
May 19, 2020
Merged

Fixed unrecognised_command() not working if the last group added has prefixes. #867

merged 2 commits into from
May 19, 2020

Conversation

vicky5124
Copy link
Contributor 

Fixed unrecognised_command() not triggering when the last group in the standard framework has a prefix.

	modified:   src/framework/standard/parse/mod.rs

@vicky5124
Fixed unrecognised_command() not triggering when the last group in th…
e2e2a09 
…e standard framework has a prefix.

	modified:   src/framework/standard/parse/mod.rs
@arqunis arqunis added fix A solution to an existing bug. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate labels May 19, 2020
arqunis
arqunis requested changes May 19, 2020
View reviewed changes
src/framework/standard/parse/mod.rs Outdated Show resolved Hide resolved
@vicky5124 @arqunis
Fixed return before modification.
2fe30fa 
Update src/framework/standard/parse/mod.rs

Co-authored-by: Alex M. M. <acdenissk69@gmail.com>
@arqunis arqunis merged commit 8040fa5 into serenity-rs:next May 19, 2020
@vicky5124 vicky5124 deleted the fix_unrecognised_command_next branch May 19, 2020 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arqunis arqunis arqunis approved these changes

Assignees
No one assigned
Labels
fix A solution to an existing bug. framework Related to the `framework` and `framework::standard` modules and/or the `command_attr` crate
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vicky5124 @arqunis