Fix all Clippy-lints for Clippy 0.0.212
#579
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`cyclomatic-complexity-threshold` to `cognitive-complexity-threshold`.
nickelc
reviewed
May 25, 2019
ghost
pushed a commit
that referenced
this pull request
Jun 24, 2019
Revert the 'say' method in the impl of 'guildchannel' from taking self. This was accidentally done in a Clippy lint PR[1]. This is a breaking change, but is a bugfix, so a patch increase is fine. [1]: #579 Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
Lakelezz
pushed a commit
that referenced
this pull request
Jun 24, 2019
Revert the 'say' method in the impl of 'guildchannel' from taking self. This was accidentally done in a Clippy lint PR[1]. This is a breaking change, but is a bugfix, so a patch increase is fine. [1]: #579 Signed-off-by: Zeyla Hellyer <zeyla@hellyer.dev>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates Serenity's code to adhere to lints triggered by Clippy version
0.0.212.Some lints got allowed that are not helpful or false-positives.
On another note, this removes the explicit impl BuildHasher on
owners'HashSet<UserId>which was introduced to please Clippy in a prior commit.