Modify Args internals to a lexer approach
#326
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@serenity-rs/ferris-elite-collection-of-epic-code please review |
Lakelezz
reviewed
Jun 4, 2018
src/framework/standard/args.rs
Outdated
| @@ -261,7 +359,10 @@ impl Args { | |||
| &s[1..end] | |||
| } | |||
|
|
|||
| /// The amount of args. | |||
| /// The full amount of recognized arguments. | |||
There was a problem hiding this comment.
Since we settled for British English, we should write recognised.
Lakelezz
reviewed
Jun 4, 2018
src/framework/standard/args.rs
Outdated
| self.offset >= self.args.len() | ||
| } | ||
|
|
||
| /// Go one step behind |
There was a problem hiding this comment.
Forgot a dot after behind.
Lakelezz
reviewed
Jun 4, 2018
src/framework/standard/args.rs
Outdated
| /// | ||
| /// let mut args = Args::new("42 69 95", &[" ".to_string()]); | ||
| /// | ||
| /// // Lets parse 'em numbers! |
Lakelezz
reviewed
Jun 4, 2018
src/framework/standard/args.rs
Outdated
| /// | ||
| /// // Oh, no! I actually wanted to multiply all of them by 2! | ||
| /// // I don't want to call `rewind` 3 times manually.... | ||
| /// // Wait, i could just go entirely back! |
Lakelezz
reviewed
Jun 4, 2018
src/framework/standard/args.rs
Outdated
| @@ -316,25 +483,12 @@ impl Args { | |||
| /// | |||
| /// assert_eq!(args.len_quoted(), 2); // `2` because `["42", "69"]` | |||
| /// ``` | |||
| #[deprecated(since = "0.5.3", note = "its task was merged with `len`, please use it instead.")] | |||
There was a problem hiding this comment.
Should depreciation-notes start capitalised?
There was a problem hiding this comment.
Not really.
Though, i suppose i could.
Lakelezz
approved these changes
Jun 4, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an overhaul to the method-of-parsing things into "arguments" to an approach that's:
Also, for convenience, this adds 2 new methods:
rewind- Goes one step behindrestore- Goes back to the start(And tweaks docs as well)