Use #[serde(remote = "Self")] to simplify serde impls #2287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arqunis
approved these changes
Nov 16, 2022
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Feb 28, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 18, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
May 30, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Sep 21, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 17, 2023
mkrasnitski
pushed a commit
to mkrasnitski/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
arqunis
pushed a commit
to arqunis/serenity
that referenced
this pull request
Oct 24, 2023
This was referenced Dec 24, 2023
arqunis
pushed a commit
that referenced
this pull request
Dec 24, 2023
Specifically, the `members` field was being incorrectly deserialized. In #2287, the logic for collecting the received array of members into a hashmap was removed, meaning the deserializer now looked for a map instead of a sequence, causing deserialization to fail. This PR adds that logic back. Closes #2666
mkrasnitski
added a commit
that referenced
this pull request
Dec 24, 2023
Specifically, the `members` field was being incorrectly deserialized. In #2287, the logic for collecting the received array of members into a hashmap was removed, meaning the deserializer now looked for a map instead of a sequence, causing deserialization to fail. This PR adds that logic back. Closes #2666
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multiple places, serenity used manual Deserialize implementations because it had to intervene in the deserialization process. The actual intervention is almost always small, but in turn, the entire deserialization process had to be rewritten.
This PR changes applicable places to use the Deserialize derive instead with the
#[serde(remote = "Self")]attribute. This attribute makes serde generate the deserialize+serialize methods as private inherent methods instead of as trait implementations. Therefore, a manual deserialization implementation can easily delegate to those inherent methods and implement their special behavior on top of them.