Skip to content
This repository has been archived by the owner on May 6, 2020. It is now read-only.

Does not build on nightly >= 2015-12-05 #56

Closed
sgrif opened this issue Dec 6, 2015 · 1 comment
Closed

Does not build on nightly >= 2015-12-05 #56

sgrif opened this issue Dec 6, 2015 · 1 comment
Labels
does not compile

Comments

@sgrif
Copy link

sgrif commented Dec 6, 2015

Noticed when Diesel's build started being red. Looks like it's due to rust-lang/rust#29850. Gonna take a swing at this, but opening an issue in case I don't finish this morning (going on vacation, w/ the worlds slowest internet atm)
sgrif added a commit to sgrif/aster that referenced this issue Dec 6, 2015
@sgrif
Update for rust-lang/rust#29850
7e0a588 
This will of course break the build on stable, as syntex_syntax will
need to be updated as well. The suite now passes on nightly, however.
Though the pull request upstream which broke this adds support for
attributes in statement and expression contexts, I've opted not to
actually support it here yet, as we presumably cannot handle that on
stable for at least 2 more Rust versions.

Fixes serde-deprecated#56
@sgrif sgrif mentioned this issue Dec 6, 2015
Closed
@erickt
Copy link

erickt commented Dec 8, 2015

Should be fixed now!

@erickt erickt closed this as completed Dec 8, 2015
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
does not compile
Milestone
No milestone
Development

No branches or pull requests
3 participants
@erickt @sgrif @dtolnay