Skip to content

Commit

Permalink
Address comments
Browse files Browse the repository at this point in the history
  • Loading branch information
serbel324 committed Apr 2, 2024
1 parent 347cbdd commit 92e7151
Show file tree
Hide file tree
Showing 2 changed files with 6 additions and 5 deletions.
10 changes: 5 additions & 5 deletions ydb/core/load_test/group_write.cpp
Original file line number Diff line number Diff line change
Expand Up @@ -446,7 +446,7 @@ class TLogWriterLoadTestActor : public TActorBootstrapped<TLogWriterLoadTestActo
// There is no point in having more than 1 active garbage collection request at the moment
constexpr static ui32 MaxGarbageCollectionsInFlight = 1;

std::shared_ptr<NJaegerTracing::TThrottler> TracingThrottler;
TIntrusivePtr<NJaegerTracing::TThrottler> TracingThrottler;

public:
TTabletWriter(TIntrusivePtr<::NMonitoring::TDynamicCounters> counters,
Expand All @@ -457,7 +457,7 @@ class TLogWriterLoadTestActor : public TActorBootstrapped<TLogWriterLoadTestActo
TIntervalGenerator garbageCollectIntervalGen,
TDuration scriptedRoundDuration, TVector<TReqInfo>&& scriptedRequests,
const TInitialAllocation& initialAllocation,
const std::shared_ptr<NJaegerTracing::TThrottler>& tracingThrottler)
const TIntrusivePtr<NJaegerTracing::TThrottler>& tracingThrottler)
: Self(self)
, TagCounters(counters->GetSubgroup("tag", Sprintf("%" PRIu64, Self.Tag)))
, Counters(TagCounters->GetSubgroup("channel", Sprintf("%" PRIu32, channel)))
Expand Down Expand Up @@ -1227,12 +1227,12 @@ class TLogWriterLoadTestActor : public TActorBootstrapped<TLogWriterLoadTestActo

TIntervalGenerator garbageCollectIntervalGen(profile.GetFlushIntervals());

std::shared_ptr<NJaegerTracing::TThrottler> tracingThrottler;
TIntrusivePtr<NJaegerTracing::TThrottler> tracingThrottler;

ui32 throttlerRate = profile.GetTracingThrottlerRate();
if (throttlerRate) {
tracingThrottler.reset(new NJaegerTracing::TThrottler(throttlerRate, profile.GetTracingThrottlerBurst(),
TAppData::TimeProvider));
tracingThrottler = MakeIntrusive<NJaegerTracing::TThrottler>(throttlerRate, profile.GetTracingThrottlerBurst(),
TAppData::TimeProvider);
}

for (const auto& tablet : profile.GetTablets()) {
Expand Down
1 change: 1 addition & 0 deletions ydb/core/load_test/ya.make
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@ PEERDIR(
ydb/core/blobstorage/pdisk
ydb/core/control
ydb/core/keyvalue
ydb/core/jaeger_tracing
ydb/core/kqp/common
ydb/core/kqp/rm_service
ydb/core/tx/columnshard
Expand Down

0 comments on commit 92e7151

Please sign in to comment.